Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed helm chart values and master-config.yaml #9788

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix: fixed helm chart values and master-config.yaml #9788

merged 1 commit into from
Aug 2, 2024

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Aug 2, 2024 •
edited by jira bot
Loading

Ticket

Description

Added clusterName to master-config.yaml and fixed how defaultNamespace is called in it.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Aug 2, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.05%. Comparing base (fe14062) to head (0e6a6d2).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9788   +/-   ##
=======================================
  Coverage   54.05%   54.05%           
=======================================
  Files        1260     1260           
  Lines      155574   155574           
  Branches     3504     3502    -2     
=======================================
+ Hits        84088    84089    +1     
+ Misses      71340    71339    -1     
  Partials      146      146
Flag Coverage Δ
backend 44.90% <ø> (+<0.01%) ⬆️
harness 72.62% <ø> (ø)
web 53.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@salonig23 salonig23 requested a review from maxrussell August 2, 2024 21:14
@netlify Netlify
Copy link

netlify bot commented Aug 2, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 0e6a6d2
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66ad4c2a74394a0008c1e77b

@salonig23 salonig23 marked this pull request as ready for review August 2, 2024 21:14
@salonig23 salonig23 added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Aug 2, 2024
amandavialva01
amandavialva01 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@amandavialva01 amandavialva01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@salonig23 salonig23 merged commit a034964 into main Aug 2, 2024
87 of 101 checks passed
@salonig23 salonig23 deleted the fix-helm branch August 2, 2024 21:38
github-actions bot pushed a commit that referenced this pull request Aug 2, 2024
@salonig23 @determined-ci
fix: fixed helm chart values and master-config.yaml (#9788)
f144957 
(cherry picked from commit a034964)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxrussell maxrussell maxrussell approved these changes

@amandavialva01 amandavialva01 amandavialva01 approved these changes

Assignees
No one assigned
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salonig23 @maxrussell @amandavialva01